Update svd.jl documentation #56611
Closed
Update svd.jl documentation #56611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QRIteration() is not exported, so I updated the svd.jl documentation section that suggests such a method exists for the `svd` function. Now it says to use `alg = LinearAlgebra.QRIteration()` instead of `alg = QRIteration()` which would produce an error before.
Member
|
Same on the line above? |
Member
|
I believe this should now go to the LinearAlgebra.jl repo, right? |
Member
|
Please move this pr to https://github.com/JuliaLang/LinearAlgebra.jl |
jishnub
pushed a commit
to JuliaLang/LinearAlgebra.jl
that referenced
this pull request
Dec 20, 2024
> QRIteration() is not exported, so I updated the svd.jl documentation section that suggests such a method exists for the `svd` function. Now it says to use `alg = LinearAlgebra.QRIteration()` instead of `alg = QRIteration()` which would produce an error before. ```jl julia> VERSION v"1.11.2" julia> using LinearAlgebra julia> DivideAndConquer ERROR: UndefVarError: `DivideAndConquer` not defined in `Main` Suggestion: check for spelling errors or missing imports. julia> QRIteration ERROR: UndefVarError: `QRIteration` not defined in `Main` Suggestion: check for spelling errors or missing imports. julia> LinearAlgebra.DivideAndConquer LinearAlgebra.DivideAndConquer julia> LinearAlgebra.QRIteration LinearAlgebra.QRIteration ``` Moved from JuliaLang/julia#56611 --------- Signed-off-by: Chengyu HAN <[email protected]> Co-authored-by: Ali Hamed Moosavian <[email protected]>
Member
|
Replaced by JuliaLang/LinearAlgebra.jl#1151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QRIteration() is not exported, so I updated the svd.jl documentation section that suggests such a method exists for the
svdfunction. Now it says to usealg = LinearAlgebra.QRIteration()instead ofalg = QRIteration()which would produce an error before.